fix: do not handle write errors after request is aborted #28722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
This fixes a flake on linux CI which started recently where the "write" promise is being rejected after the request has been aborted / cancelled. In this case we should drop the error to the floor but instead we pass it down the stack where it eventually emits a now unhandled error event. Example failure: https://app.circleci.com/pipelines/github/electron/electron/38072/workflows/c1faf19b-aa41-4f99-a564-165729222859/jobs/838813 Verified fix by running the test that caused it 10000 times before fix and 10000 times after. ~50 failures before, 0 after.
trop
bot
added
11-x-y
backport
MarshallOfSound
approved these changes
Apr 19, 2021
|
No Release Notes |
trop
bot
deleted the
trop/11-x-y-bp-fix-do-not-handle-write-errors-after-request-is-aborted-1618840240721
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #28682
See that PR for details.
Notes: no-notes